search

ttroy50 / cmake-examples

Useful CMake Examples
http://ttroy50.github.io/cmake-examples
MIT License
12.45k stars 2.5k forks source link

fix: fix CMakeLists.txt in chapter H #57

Closed sf624 closed 3 years ago

sf624 commented 3 years ago

First of all, thank you for this helpful tutorial.

In my understanding, the intent of chapter H was to show linking using Non-alias targets. Imported alias targets was rather used in chapter K, so it seems the content is duplicated.

ttroy50 commented 3 years ago

Thanks for the PR but I'd prefer to show the alias targets as the default here as it is the more "modern" and recommended way to import third party libraries. In the description of this chapter I describe the difference between alias libraries and non-alias libraries.

w/hile there is some duplication with chapter K, I think that is ok for what I'm trying to show