search

ttscoff / Slogger

Social logging script for Day One
757 stars 160 forks source link

lastfmcovers logging incorrect date (off by 273 years) & not pulling in covers #376

Open itsbrex opened 9 years ago

itsbrex commented 9 years ago

2 Centuries, 7 Decades, 3 years, 9 months, 1 week, and 4 days to be exact.

It's pulling in the scrobbled track data just fine, just not getting the covers and logging it to the correct date.

lastfm logger

Here is what I have in my slogger_config file. Btw, even though I have the lastfmcovers.rb plugin enabled (and not the lastfmlogger.rb one) when I update the config, it still pulls in the LastFMLogger title as you can see below. 

LastFMLogger:
  lastfm_description:
  - Logs songs scrobbled for time period.
  - lastfm_user is your Last.fm username.
  - lastfm_feeds is an array that determines whether it grabs recent tracks, loved
    tracks, or both
  - lastfm_include_timestamps (true/false) will add a timestamp prefix based on @time_format
    to each song
  LastFMLogger_last_run: Fri Jun 26 22:18:30 2015
  lastfm_include_timestamps: true
  lastfm_user: ANODIGITAL
  lastfm_covers: true
  lastfm_chunk: ''
  lastfm_feeds:
  - recent
  - loved
  lastfm_tags: '#social #music'
ttscoff commented 9 years ago

I don't know what the lastfmcovers plugin is. You should find the author of that and request support from him or her.

-Brett

On 27 Jun 2015, at 0:58, Brian Roach wrote:

2 Centuries, 7 Decades, 3 years, 9 months, 1 week, and 4 days to be exact.

It's pulling in the scrobbled track data just fine, just not getting the covers and logging it to the correct date.

lastfm logger

Here is what I have in my slogger_config file. Btw, even though I have the lastfmcovers.rb plugin enabled (and not the lastfmlogger.rb one) when I update the config, it still pulls in the LastFMLogger title as you can see below.

LastFMLogger:
lastfm_description:
- Logs songs scrobbled for time period.
- lastfm_user is your Last.fm username.
- lastfm_feeds is an array that determines whether it grabs recent 
tracks, loved
 tracks, or both
- lastfm_include_timestamps (true/false) will add a timestamp prefix 
based on @time_format
 to each song
LastFMLogger_last_run: Fri Jun 26 22:18:30 2015
lastfm_include_timestamps: true
lastfm_user: ANODIGITAL
lastfm_covers: true
lastfm_chunk: ''
lastfm_feeds:
- recent
- loved
lastfm_tags: '#social #music'

Reply to this email directly or view it on GitHub: https://github.com/ttscoff/Slogger/issues/376

itsbrex commented 9 years ago

Hi Brett,

Bare with me - I'm still learning how github and all this works.

So I downloaded the zip from the main Slogger repo and the lastfmcovers plugin was in the plugins_disabled folder. It does say "Based off Brett Terpstra's...with additions from Micah Cooper." Does that mean I should go to his page and open an issue or is there a way to tag him from here? What is the protocol?

Brian

ttscoff commented 9 years ago

Yes, or just @ mention his username in this thread to get him in on it. I haven't seen this date issue in my version yet, but not 100% that it's not a shared issue.

On Jun 27, 2015, at 8:57 AM, Brian Roach notifications@github.com wrote:

Hi Brett,

Bare with me - I'm still learning how github and all this works.

So I downloaded the zip from the main Slogger repo and the lastfmcovers plugin was in the plugins_disabled folder. It does say "Based off Brett Terpstra's...with additions from Micah Cooper." Does that mean I should go to his page and open an issue or is there a way to tag him from here? What is the protocol?

Brian

— Reply to this email directly or view it on GitHub.

itsbrex commented 9 years ago

Ok. Sounds good. @coopermj could you please chime in on this. Having some trouble with the lastfmcovers.rb gem

coopermj commented 9 years ago

Well, that’s weird behavior. Just for fun, switch lastfm_chunk: from ‘’ to completely blank.

It’s still purring along on my system and this is the only time I’ve heard someone having this problem.

On Jun 27, 2015, at 1:25 PM, Brian Roach notifications@github.com<mailto:notifications@github.com> wrote:

Ok. Sounds good. @coopermjhttps://github.com/coopermj could you please chime in on this. Having some trouble with the lastfmcovers.rb gem

— Reply to this email directly or view it on GitHubhttps://github.com/ttscoff/Slogger/issues/376#issuecomment-116106138.

itsbrex commented 9 years ago

No luck. Wouldn't run if I removed the ''

coopermj commented 9 years ago

Weird – that’s how mine is set. I just updated to the latest Slogger codebase and switched to Day One sync and it still works. When you use the original LastFM plugin, does it follow the same behavior?

On Jun 29, 2015, at 4:30 PM, Brian Roach notifications@github.com<mailto:notifications@github.com> wrote:

No luck. Wouldn't run if I removed the ''

— Reply to this email directly or view it on GitHubhttps://github.com/ttscoff/Slogger/issues/376#issuecomment-116834366.

crcastle commented 9 years ago

This bug still exists. @coopermj did you test the configuration where lastfm_chunk is set to nothing (either empty string or blank)? The bug is pretty clear in that configuration.

Here you set periodDays to 99999. Then here you add periodDays to targetDate to get endDate. endDate is then used as the timestamp for the Day One journal entry.

I stopped debugging after finding this because I'm having a hard time following the code. So until this is fixed, the lastfm_chunk config parameter must be set to daily (I bet weekly gives the wrong date too, but I didn't test it). But even when set to daily, I'm finding the Day One journal entry time to be off by about a day in the future, so I'm dumping this and going with a non-slogger IFTTT.com/Hazel solution that I just got working.

Sorry if this comes off negative. Just getting a bit frustrated with the general code quality and brittleness of Slogger plugins.

ttscoff commented 9 years ago

I think a refund is in order.

On Nov 14, 2015, at 2:10 AM, Chris Castle notifications@github.com wrote:

This bug still exists. @coopermj did you test the configuration where lastfm_chunk is set to nothing (either empty string or blank)? The bug is pretty clear in that configuration.

Here you set periodDays to 99999. Then here you add periodDays to targetDate to get endDate. endDate is then used as the timestamp for the Day One journal entry.

I stopped debugging after finding this because I'm having a hard time following the code. So until this is fixed, the lastfm_chunk config parameter must be set to daily (I bet weekly gives the wrong date too, but I didn't test it). But even when set to daily, I'm finding the Day One journal entry time to be off by about a day in the future, so I'm dumping this and going with a non-slogger IFTTT.com/Hazel solution that I just got working.

Sorry if this comes off negative. Just getting a bit frustrated with the general code quality and brittleness of Slogger plugins.

— Reply to this email directly or view it on GitHub.

crcastle commented 9 years ago

Heh, I know @ttscoff... I do really appreciate the work you and others have done creating slogger. Apologies for my "entitled" response.

ttscoff commented 9 years ago

Apologies for my "dickish" response, it was early in the morning :/.

On Nov 14, 2015, at 3:13 PM, Chris Castle notifications@github.com wrote:

Heh, I know @ttscoff... I do really appreciate the work you and others have done creating slogger. Apologies for my "entitled" response.

— Reply to this email directly or view it on GitHub.

coopermj commented 9 years ago

I suppose all that’s left is for me to apologize for my lousy code! ;)

Anyway, I think I’ve found the issue. Well, first issue is this is my first ruby script. Second, I’m attempting to solve 3 use cases in one and set the entry date to the period end instead of the period beginning. Obviously exacerbated by the long-period run. Anyway, I’m not a regular git user, so when I get that sorted out, I’ll issue a pull request with the fix.

On Nov 14, 2015, at 10:36 PM, Brett Terpstra notifications@github.com<mailto:notifications@github.com> wrote:

Apologies for my "dickish" response, it was early in the morning :/.

On Nov 14, 2015, at 3:13 PM, Chris Castle notifications@github.com<mailto:notifications@github.com> wrote:

Heh, I know @ttscoff... I do really appreciate the work you and others have done creating slogger. Apologies for my "entitled" response.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/ttscoff/Slogger/issues/376#issuecomment-156775970.

crcastle commented 9 years ago

Thanks @coopermj and again sorry for my crankiness! I appreciate your contributions!