ttskch / select2-bootstrap4-theme

Select2 v4 theme for Bootstrap4
MIT License
434 stars 207 forks source link

Bootstrap variable file should not be introduced in layout.css #43

Closed zhnoah closed 4 years ago

zhnoah commented 4 years ago

If I use gulp-sass instead of sass-loader to compile SCSS source code, I will not be able to proceed.

I think it is better to add in webpack.config.js:

{
    loader: 'sass-loader',
    options: {
        prependData: `
            @import "~bootstrap/scss/functions";
            @import "~bootstrap/scss/variables";
            @import "~bootstrap/scss/mixins";
        `
    }
}
dangelion commented 4 years ago

@zhnoah is totally right, these @import

@import "~bootstrap/scss/functions";
@import "~bootstrap/scss/variables";
@import "~bootstrap/scss/mixins";

have not to be imported there. Here this causes serious issues when using Bootstrap with RFS enabled. Please, could you fix it? Thanks

zhnoah commented 4 years ago

@dangelion

see here

ttskch commented 4 years ago

@zhnoah @dangelion Sorry for my late response. I've just fixed this via e946eed. I'm publishing soon. Thanks.