search

ttskch / select2-bootstrap4-theme

Select2 v4 theme for Bootstrap4
MIT License
435 stars 206 forks source link

Get the primary theme colour properly #50

Closed intiocean closed 3 years ago

intiocean commented 4 years ago

Using the bootstrap function to get the theme colour means that the source can be used by people who have overridden the primary theme colour by setting it in $theme-colours as per bootstrap docs

https://getbootstrap.com/docs/4.5/getting-started/theming/#modify-map

Fixes #46

ttskch commented 3 years ago

@intiocean Thanks for your contribution! But I think some ways like #51 will be better for this issue.

intiocean commented 3 years ago

@ttskch I don't see how #51 fixes this? Surely this should follow any overrides supplied to bootstrap without having to also add the same overrides in a different format for this select2 plugin?