search

ttskch / select2-bootstrap4-theme

Select2 v4 theme for Bootstrap4
MIT License
435 stars 206 forks source link

Updated toolchain, impoved multiselects and compatibility to select2 4.1 #56

Closed weberhofer closed 2 months ago

weberhofer commented 4 years ago

This RP fixes #49

ttskch commented 3 years ago

@weberhofer Thanks for your contribution! I updated toolchain on https://github.com/ttskch/select2-bootstrap4-theme/commit/993dea8b7fd0f755202f26afc066f94ffb8abb7a . And I cannot merge this PR to master branch because it breaks BC for users of select2 4.0. I will create a new branch to support select2 4.1. Please wait a moment. Thanks.

tagliala commented 3 years ago

Hi @ttskch

Select 2 4.1 is now in RC. Most of the things already seems to work, if you create a branch I can help to check the missing ones

tagliala commented 3 years ago

This branch contains an opinionated reimplementation of this theme working with Select2 4.1 RC0

I've used Bootstrap 4's custom-select to improve uniformity

I've tested on:

I can't test on IE 10

NordicAT commented 3 years ago

@tagliala I have tested your reimplementation. I like it, but there seems to be a bug with an empty multiselect. Have a look at the following screenshot:

Select2-Multiselect

tagliala commented 3 years ago

@NordicAT thanks. I've opened a new PR at #67

I like it, but there seems to be a bug with an empty multiselect.

I've added some extra fields to the demo for testing purposes. Any chance to share the original HTML so I can reproduce?

tagliala commented 3 years ago

@NordicAT nope. Tested on windows chrome / firefox / edge / ie11

Can we continue at #67? we are off topic here