search

ttskch / select2-bootstrap4-theme

Select2 v4 theme for Bootstrap4
MIT License
436 stars 203 forks source link

Update the disabled multi-select SCSS to hide the remove #58

Closed garretthyder closed 3 years ago

garretthyder commented 4 years ago

In select2 by default the X is removed from option pills in the multiselect. With this theme enabled that behaviour is overriden and shows the x along with it having the hover state.

Screen Shot 2020-07-20 at 4 20 38 PM

This change suppresses the x on the option pills when disabled.

Screen Shot 2020-07-20 at 11 11 11 AM

Also suppresses the input field to avoid the case when there's enough options to fill the line leaving a seemingly empty line after the options.

Screen Shot 2020-07-20 at 4 22 17 PM

So now that empty space doesn't occur;

Screen Shot 2020-07-20 at 4 22 43 PM
ttskch commented 3 years ago

@garretthyder Thanks for your contribution! I've just committed https://github.com/ttskch/select2-bootstrap4-theme/commit/a4cca3a7c66bff362d9ddd91927f108c404d46f1 and https://github.com/ttskch/select2-bootstrap4-theme/commit/a37a14a49e2108c195185c55244afd58d0b5249f. I think they resolves the problem which this PR focused. Thanks.