Chapter 14 Websockets

[hfbeigit]

Hi Pieter, i just found your tutorial on the ESP and Websockets in special. Very nice work. Great entry for a quickstart. I did not test your code yet, but while reading the example i saw some minor things in the code. For the sakes of a tutorial the code is very readable. As a full time developer i am wondering

• why the if condition? hue = ++hue % 360 would do the job (see later in your code hue %= 360)

  if(++hue == 360) // Cycle through the color wheel (increment by one degree every 32 ms) hue = 0;

• function setHue: why the extra conditions in each if clause?

  if(hue>=0 && hue<120)

  In your code hue will never go below zero, so hue >= 0 will always be true in your example. In the wide wild world this might be another topic else if(hue>=120 && hue<240)

  when the code reaches this point, the hue value definitely is greater or equal to 120. hue >= 120 will always be true, so not needed. else if(hue>=240 && hue<360)

  No if needed at all. When the code reaches this point, the hue value allways will be greater or equal to 240 and allways below 360 (see the line hue %= 360 and the way you increment the hue value)

I do not want to criticise, just leaving my 2 cents

[tttapa]

Thanks a lot for your feedback, I appreciate it!

I currently have exams, but I'll definitely look into it when I find the time in a couple of weeks. I've got some other edits ready as well (some typos, things that changed with new updates from the Core software, etc.), but I have to do a serious revision first, before I push to production.