Adding Sustain CC 64.

[rabbiccu]

Everything so far is working great, I am very happy with my midified organ. So far I have all potentiometers. How do I add a sustain pedal? This would be a digital input on cc# 64.

[tttapa]

The master branch has a class DigitalCC that you could use.

[rabbiccu]

All the examples I can find are for triggering a note. Is there an example of using digital reads to send midi cc, the same way the analog class is used?

[tttapa]

You could use something like this:

const pin_t sustainPin = 2;
const uint8_t channel = 1;

DigitalCC sustainPedal = { sustainPin, MIDI_CC::Damper_Pedal, channel };

[rabbiccu]

So this didn't work although I'm not sure I am doing this right.

The sustain pedal just passes 5v through it to the appropriate input on my Leonardo. As I'm very familiar now with the analog input scheme is there a way to just use that scheme instead of the DigitalCC class, which isn't working and I have no idea how to use?

I'm thinking something like this: Analog potentiometer(A0, MIDI_CC:: Damper_Pedal, 1); and the pedal itself is wired between the A0 input and the 5V supply.

[tttapa]

Usually, switches are wired as explained here.

If you cannot connect it to ground, you need to invert it in software: https://github.com/tttapa/MIDI_controller/blob/79070e9531d738d1e47a8c6d94b4a5c4e502fe28/src/MIDI_Outputs/DigitalCC.cpp#L15-L18

[rabbiccu]

Seems like the footswitch, which only has two terminals, just closes/opens the circuit. When the circuit is open it would pass 0v and when closed would pass 5v? Like this from Dave's MIDI CC List says:

On/Off switch that controls sustain. (See also Sostenuto CC 66) 0 to 63 = Off, 64 to 127 = On

I am going out to try this on an analog input today.

[tttapa]

No, if the switch is open (not pressed), the voltage on the Arduino input is 5V, because it's pulled up through the internal pull-up resistor (it's inside of the Arduino). If the switch is closed, it pulls the voltage low to ground, so the input is at 0V.

That's all you have to worry about, the MIDI Controller library will handle the rest for you.

[rabbiccu]

Ok so I'll just throw your code above in before i name the inputs. Will I use a digital input or an analog input?

[tttapa]

Digital, because a switch is digital.

[rabbiccu]

#include <MIDI_Controller.h> // Include the library

 void DigitalCC::invert()  // Invert the button state 
 { 
   invertState = true; 
 } 

const pin_t sustainPin = 2;
const uint8_t channel = 1;

DigitalCC sustainPedal = { sustainPin, MIDI_CC::Damper_Pedal, channel 1};

//here all my working analog input code

void setup() {}

void loop() {

  MIDI_Controller.refresh();
}

Is this good code to start with if the pedal is between Digital Input 2 and 5V? BTW thanks!

[tttapa]

No. I don't know if your pedal can be wired up to ground, but if so, you have to follow the schematic I posted above.

Also delete lines 3-6.

[rabbiccu]

I'm saying it cant be wired to ground and doesnt have a ground terminal, just two wires coming out of the pedal.

So in that case I would need to have lines 3-6 to invert, right?

[tttapa]

What do you mean "it can't be wired to ground"? Tip to digital input pin, sleeve to ground, done.

[rabbiccu]

Sorry, so then no 5V?

[tttapa]

No, the switch in the schematic (S1) just has two terminals. The resistor is inside of the Arduino.

[rabbiccu]

This worked.

[tttapa]

Great! Glad to hear.