search

tttapa / py-build-cmake

Modern, PEP 517 compliant build backend for creating Python packages with extensions built using CMake.
https://pypi.org/project/py-build-cmake
MIT License
38 stars 6 forks source link

Request mypy and cmake as dependencies #26

Closed albertopasqualetto closed 4 weeks ago

albertopasqualetto commented 4 weeks ago

Put cmake as dependency since it is small and it makes it build even if it is not already present system-wide.

mypy is needed for stubgen (maybe only in linux)

tttapa commented 4 weeks ago

Hi @albertopasqualetto

Thanks for the PR!

The cmake and mypy dependencies should be added automatically, depending on whether they're available already. The code for this feature is here:

https://github.com/tttapa/py-build-cmake/blob/420f73ca8c4e1b91c1adeddfba3afd697eaeba36/src/py_build_cmake/build.py#L181-L192

What is the reason for adding them as unconditional dependencies? Is the approach above not working correctly for you?

albertopasqualetto commented 4 weeks ago

Ok, I understand, for some reason it did not work for me

albertopasqualetto commented 4 weeks ago

Now it is working for some reason: I updated pip