search

tttor / csipb-jamu-prj

Ijah Webserver
http://ijah.apps.cs.ipb.ac.id
MIT License
5 stars 12 forks source link

Rename component v1 to ijahv1 under webserver/src/app #176

Closed tttor closed 7 years ago

hzbarkan commented 7 years ago

Would be warned since ng2 is persuading to name any component wih "Component" so the proper naming would be "ijahV1Component" sir

tttor commented 7 years ago

how about ijahv1.component.ts? as we want to move to ang4 eventually, if not: then ijahV1Component is OK. The point is that we should not name it merely "v1" Thank you.

hzbarkan commented 7 years ago

Thanks sir, as the filename is okay, but the problem is for the class name (in export class -classname- and the imported class in other components) so what i mean is the filename is ijahv1.component.ts and the exported class name and the folder name is ijahV1Component

I got the point that the vault is naming it as "V1Component" at first, thanks sir

tttor commented 7 years ago

OK then, pls do then close this then, thanks

hzbarkan commented 7 years ago

done