tttsaurus / Fluid-Interaction-Tweaker

This is a (1.12.2 Minecraft Forge) CraftTweaker/GroovyScript addon that enables you to add more fluid interactions
https://www.curseforge.com/minecraft/mc-mods/fluid-interaction-tweaker
MIT License
2 stars 0 forks source link

Missed vanilla interaction `Water Source` + `Lava` = `Stone` #3

Closed Krutoy242 closed 1 month ago

Krutoy242 commented 1 month ago

Only Cobblestone and Obsidian is listed in JEI, but there is should be third one with Stone.

image

tttsaurus commented 1 month ago

well, i added the desc for Stone image

showing various outputs requires me to refactor my framework and i dont decide to do that currently

the reason is that you can add whatever mechanism you want for the output block (so many variations are possible) by listening to the event, so i think showing desc for the output block is the best solution

Krutoy242 commented 1 month ago

I believe players always bored to read. Can you make scrolling ingredient? I know JEI allow to make lists of items for a single slot. So it could just scroll between Cobble and Stone, so players will see different output without checking nasty texts.

tttsaurus commented 1 month ago

if im adding this scrolling feature, then it shouldn't be only vanilla compat. ill probably add some optional parameters in addRecipe method to display the scrolling things, but only for jei not really refactoring

do you think scrolling outputs + desc is enough?

Krutoy242 commented 1 month ago

some optional parameters

Why optional parameters? ZS have great tool IBlockPattern that hold many blocks. Just make outputBlock parameter as pattern instead of IBlock. The perfect solution would be if function could accept not only IBlockPattern but also IIngredient because im 100% sure that in my modpack i will make complicated interactions with resulted blocks that cant be interpreted as items to fit JEI item slot, such as vanilla fire. So, for actual interaction i will need to use block, but for JEI integration - item representation of this block.

scrolling outputs + desc

No desc, only scrolling. Also, you dont need special handlers in your mod for description - ZS allows to add lore to item outputs.

tttsaurus commented 1 month ago

For the first thing, image this is why i was not considering IIngredient in order to to be more generic, ill probably change that map value to ComplexOutput sth which is a class that is just in my mind, and it also requires refactorization

ComplexOutput should be able to spawn mobs items also by conditions sth. Then jei becomes huge, i really need some time to work on that

For the second thing, if i finished the ComplexOutput and its corresponding jei compat, then desc or scrolling isn't a thing anymore

tttsaurus commented 1 month ago

image image refer to v1.4.0-preview-1

Krutoy242 commented 1 month ago

Looks great!

Krutoy242 commented 1 month ago

In E2EE this tooltip looks shifted and out of tooltip panel. It position depends on GUI size. This may be related to ScalingGUIs mod.

image

image

tttsaurus commented 1 month ago

i'll try to fix that. btw, why your thaumcraft is rendering aspects inside jei? i also have thaumcraft installed when testing

Krutoy242 commented 1 month ago

Its some kind of addon i guess that adds aspects as tooltips.

tttsaurus commented 1 month ago

fluidintetweaker-1.4.0-preview-1-hotfix-1.zip

just for you to test (not a release)

Krutoy242 commented 1 month ago

image Fixed!