mikhailshvets
commented
4 years ago - added TypeScript implementation
- fixed #28
Closed mikhailshvets closed 4 years ago
mikhailshvets
commented
4 years ago 
BeckyWu220
commented
4 years ago Hi @mikhailshvets Thank you very much for the PR. It is a great improvement to this library. We had reviewed your PR, and found in a new folder, ./lib committed.
I believe the folder includes all the compiled code generated by npm run build. If my assumption is correct, it is not necessary to be committed because it would cause a great amount of git diff in the future.
Please add the folder to .gitignore file, and untrack these *.js and *.js.mapfiles. We are working on a automation release Github action, we can run the build script before releasing to npm.
If you have any questions or concerns, please let us know. Thanks a lot for your contribution!
mikhailshvets
commented
4 years ago Hi @BeckyWu220 Could you review the changes and accept the PR if everything is ok now?
BeckyWu220
commented
4 years ago Hi, @mikhailshvets Thanks for making the change rapidly. To merge this PR without back-and-forth change, we had created a new PR based on this PR. We had listed the 3 things we changed upon your awesome work, please feel free to check them out, and let us know if you have any questions or concerns.
example folder, we found it caused failure to include the metro.config.js file. Since we are not really using the metro for bundling, we thought it's fine to skip it.npm run build script.We are doing the final testing, and are very close to release a new build generated by your typescript implementation. Since the new PR had been merged, we will close this PR next week. We'd like to thank you again for your time and contribution. As we treat this typescript integration as a great improvement to our library, we'd like to add your name into our external contributors list upon your approval. Thank you!
mikhailshvets
commented
4 years ago Hi, @BeckyWu220 Thanks for your feedback. I'd like to be an external contributor and improve the library in the future
BeckyWu220
commented
4 years ago Great! Thanks for confirmation with us. @mikhailshvets We had add you as external contributors in the README.md file. We will close this PR now.