Renji-XD
commented
1 year ago Hi,
- i don't think that requerying in this method would help as it is just executed in case of initial load/resizing or switchting between chapters in pagination. Any frequent requerying is maybe also overkill / unecessary for people not using your extension
- main audience of the reader are people reading japanese books. these often contain furigana which will create additional text nodes and therefore more frequent update to the character progress - therefore i guess the preference is to keep it on this level
In context of #21 there will probably some changes introduced - we will try to keep this one in mind for it (though i don't know when it may will be taken up) and therefore i will leave it open
I'm currently developing a chrome extension, which highlights some English words in the text, there is a compatibility issue.
the highlight function replaces the word with an HTML tag, for example, a sentence like:
may be replaced by
The problem is that the ebook-reader's code keeps the text nodes reference in the js memory: https://github.com/ttu-ttu/ebook-reader/blob/4c76cda75201b085d8511e8681b3dce0c5912918/apps/web/src/lib/components/book-reader/book-reader-continuous/character-stats-calculator.ts#L32
and use the references later: https://github.com/ttu-ttu/ebook-reader/blob/4c76cda75201b085d8511e8681b3dce0c5912918/apps/web/src/lib/components/book-reader/book-reader-continuous/character-stats-calculator.ts#L60
but after the extension replaced the text, the
paragraphtext node does not exist anymore, so when it runs intorange.selectNode(node);will throw out an error, and the page renders nothing.I think we can make some changes here to avoid such compatibility issues with extension.
Ptag instead of using the text node inside.what do you think?