search

ttulttul / ComfyUI-Iterative-Mixer

Nodes that implement iterative mixing of samples to help with upscaling quality
GNU General Public License v3.0
115 stars 9 forks source link

Something akin to the deprecated Batch Unsampler? #23

Open oliverban opened 8 months ago

oliverban commented 8 months ago

Hello!

I find that my Unsampler OOMs really quickly compared to the rest of the workflow that can take my batches no problem, I was wondering if the Batch Unsampler was going to help with that, but that thing didn't take batches at all? I'm confused. But do you know of any node that is like the unsampler but can ACTUALLY take batches for animation?

ttulttul commented 8 months ago

I would like to accommodate batch processing in my nodes, but Comfy seems to want no more than four dimensions in latent tensors. I'm going to have to ask the ComfyUI nerds to help me with this one.

That being said, I really recommend switching to the IterativeMixingSampler and IterativeMixingScheduler instead of continuing to use the Batch Unsampler in combination with the Iterative Mixing KSampler Advanced node for your workflows generally. The KSampler variants are doing something wrong - something I still haven't figured out - when doing the sampling and mixing, generating grainy output. If you use the newer Sampler node in combination with the SamplerCustom (which comes with ComfyUI), you will get perfectly smooth output. This is where all of my work is focused; the KSampler nodes are officially deprecated.