Update Gherkin and add ability to work with multiple languages

ttutisani / Xunit.Gherkin.Quick

BDD in .NET Core - using Xunit and Gherkin (compatible with both .NET Core and .NET)

MIT License

205 stars 29 forks source link

Update Gherkin and add ability to work with multiple languages #128

Open AndreSteenveld opened 2 years ago

AndreSteenveld commented 2 years ago

Gherkin was updated
All the projects now target .NET Standard 2.0
Gherkin tests in other languages are now possible

Before changing this I want to add a few more tests in emoji-lang to exercise all keywords (examples, rules, etc).

Stuff I've noticed and would like to address:

Not all files are consistent with indenting (some are tabbed, some are spaces, some are mixed)
Not all files have the same line endings
The unit test project has a GherkinFeatureBuilder which isn't used consistently

AndreSteenveld commented 2 years ago

I'm probably missing something but where can I find the appveyor.yml file? (https://www.appveyor.com/docs/build-configuration/#configuring-build)

ttutisani commented 2 years ago

I'm probably missing something but where can I find the appveyor.yml file? (https://www.appveyor.com/docs/build-configuration/#configuring-build)

There is no yml file yet. Everything worked with defaults so far, so the yml file was not necessary. If you need it and know how it works, feel free to create one.

AndreSteenveld commented 2 years ago

I got appveyor working on my account but don't have access to your account so the builds will fail here until otherwise configured. I commited the appveyor.yml file in the root which seems to work.

ttutisani commented 2 years ago

Sorry, I was in the middle of things. Is this PR ready for review?

AndreSteenveld commented 2 years ago

Yes, there are a few settings that need tweaking in appveyor settings to make sure it picks up the the yaml file over the settings configured in the GUI. (settings, nuget keys, etc) Other than that I think it is fine. I've produced a local nuget package to keep momentum I've built up in the project I wanted to use this for and so far haven't found issues.

Other than the stuff I mentioned in opening message of this PR I think this is OK. I would like to add a two features in the future;

Using named groups to map to a paramater
Adding more {...} processors, or at least making it easier to register your own

Should I create a few tickets for those?

ttutisani commented 2 years ago

Yes, please create the issue tickets for each request separately. Meanwhile, I will review this PR.

AndreSteenveld commented 2 years ago

I have been busy and on vacation for the last two weeks so I haven't spent any time on this. Later this week I want to spend some time cleaning up the emoji feature files and making sure there is a relatively complete feature to test with emoji which will hopefully take away most of the noise from the project consumer.

ttutisani commented 2 years ago

@AndreSteenveld any news? I haven't heard back from you lately.