search

ttutisani / Xunit.Gherkin.Quick

BDD in .NET Core - using Xunit and Gherkin (compatible with both .NET Core and .NET)
MIT License
205 stars 29 forks source link

Test output does not include the specification steps #2

Closed csurfleet closed 6 years ago

csurfleet commented 6 years ago

When I execute a test, I would like to see, in the test output, the steps of the BDD specification which have been executed, along with an indication of whether the step passed or failed

ttutisani commented 6 years ago

Hey, good stuff. Since you on it, just wanted to say - in case you decide to cleanup things that get on your way, while doing this, feel free to do so. I wrote up this library in 10 hours (hence the name "Quick" btw), so it may not be very clean right away. In other words, don't follow what you see as a pattern, because it's not (yet) :-).

csurfleet commented 6 years ago

Understood! I've got a pretty good first-pass implementation complete, but you'll need to give me permissions to push my branch ;)

ttutisani commented 6 years ago

Oh, I thought you would do it on your fork. Not an issue, let me see what options there are to make you a contributor.

ttutisani commented 6 years ago

Done, I've sent you a collaborator invite.

csurfleet commented 6 years ago

Awesome, I've submitted a PR :D

I've got started with a little VS extension over here: https://github.com/csurfleet/GherkinTools At the moment I'm still working out how to hook into the VS colour profiles etc so we can have code-colouization in feature files, but going forward it could let us have 'Go to definition' menus etc to hook into your Feature classes. Feel free to add any features you'd like to see into the issues, or build them in!

ttutisani commented 6 years ago

Good. I'll keep this repo link at hand. Thanks!

ttutisani commented 6 years ago

You still need to write up a quick readme about this. Also, just FYI, I'm researching how to avoid constructor param. That turned out quite complex, but maybe I'll find something. In that case, I will improve the implementation. But so far, let's ensure we have a readme for everything that the consumers will use.

ttutisani commented 6 years ago

Work in progress in PR: https://github.com/ttutisani/Xunit.Gherkin.Quick/pull/13

ttutisani commented 6 years ago

@csurfleet Can you please confirm this works fine? so that we can close the issue. I don't see a need for the readme, unless you are volunteering to describe this feature. Readme would absolutely be necessary if we had kept the constructor injection, because then we would need to provide instructions for using that correctly. With current implementation there is nothing developers need to do. It's just built in, so no necessity for instructions (not that I'm against describing the output benefits, I'm just trying to keep it flexible).

ChristianPejrup commented 6 years ago

Good work - and i really like the addition of the skipped element.

ttutisani commented 6 years ago

Good, thank you. Closing the issue.