search

ttutisani / Xunit.Gherkin.Quick

BDD in .NET Core - using Xunit and Gherkin (compatible with both .NET Core and .NET)
MIT License
205 stars 29 forks source link

Improvements #62

Closed vinla closed 6 years ago

vinla commented 6 years ago

I've added support for common steps, scenario context and backgrounds. More information in common-steps.md

ttutisani commented 6 years ago

@vinla Before I review this - common steps and context was asked several times by others, but I don't consider that as something that this framework must provide. Common steps can be achieved by inheritance. Context can be achieved by introducing a dictionary by the consumer. So those parts I'm not going to make part of this framework. i.e. please remove them. Just to explain - there is no plan to introduce plumbing and primitive optional mechanisms by this framework. It is supposed to focus on essentials only.

I will review the rest of this PR sometime later. Thanks for the effort!

vinla commented 6 years ago

@ttutisani - It's a shame you won't consider common steps and context. I think that trying to achieve common steps through inheritance alone constrains the design of the test framework, and can make it cumbersome to work with. But if you introduce common steps in unrelated classes then you need to introduce scenario context, which is why I added both. I think the changes are pretty lightweight and don't detract or affect the overall design of the library.

vinla commented 6 years ago

Closing - will create another one for background step support only