ttyborg / castlesand

Automatically exported from code.google.com/p/castlesand
0 stars 0 forks source link

Animations in houses often "over run" #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
This happens in animations of units working in houses.
The number of frames seems to not always be right, and so the animation
loops from the start, briefly showing 1 or 2 incorrect frames before moving
on to the next animation.

Take the carpenter as an example. He grabs a log, but just before he starts
sawing it an incorrect frame flashes up. (the start of the same animation,
where he is about to reach for the log)

Same thing when the farmer in the vineyard. When he has finished squashing
the grapes, he climbs out, empties the barrel and goes to sit down but then
it shows 2 frames from the start of him climbing out of the barrel, before
he returns to the idle state.

It only happens at the end of an animation set, (one loop) never part way
through one.

This makes the animations look odd. I tried to fix but got a bit confused
so gave up.
Let me know if you don't see what I mean.

Original issue reported on code.google.com by lewinjh@gmail.com on 6 Jan 2009 at 4:18

GoogleCodeExporter commented 9 years ago
Yes, thats an issue. It comes from fact that unit Idle cycle + Task advance 
take 1-2 
more frames than House animation.

Original comment by kromster80@gmail.com on 6 Jan 2009 at 7:53

GoogleCodeExporter commented 9 years ago
Fixed and verified if I'm not mistaken.

Original comment by lewinjh@gmail.com on 20 Jul 2009 at 12:33

GoogleCodeExporter commented 9 years ago
I just noticed that this still happens for the vineyard. When he is draining the
barrel, it shows some of the first frames at the end.
Funny, I thought this was fixed...

Original comment by lewinjh@gmail.com on 27 Jul 2009 at 10:53

GoogleCodeExporter commented 9 years ago
Hopefully fixed in r619

Original comment by kromster80@gmail.com on 31 Jan 2010 at 5:46

GoogleCodeExporter commented 9 years ago
Yes, it's fixed now. Thanks. :)

Original comment by lewinjh@gmail.com on 1 Feb 2010 at 1:00

GoogleCodeExporter commented 9 years ago

Original comment by kromster80@gmail.com on 15 May 2013 at 11:50