ttyborg / castlesand

Automatically exported from code.google.com/p/castlesand
0 stars 0 forks source link

Shuffle songs should not be usable while the music is disabled #58

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Disable the music
2. Turn shuffle songs off then back on again
3. Enable music

The songs are no longer shuffled. Toggling the "shuffle songs" option while the 
music is disabled seems to have no effect.

I think the best option is to disable the "shuffle songs" checkbox while the 
music is disabled, as it makes little sense to shuffle the music when it is 
turned off. We already disable the music volume slider while the music is 
turned off so it is consistent with that. Look at the way that slider is 
disabled and make it disable "shuffle songs" too :)

Could you also add the shuffle option to the main menu options screen and if 
you have time put the scroll speed slider there too? (under the "controls" 
heading)

Original issue reported on code.google.com by lewinjh@gmail.com on 9 Nov 2011 at 3:33

GoogleCodeExporter commented 9 years ago
No problem, thanks for spotting this.

Original comment by danbry...@gmail.com on 10 Nov 2011 at 12:43

GoogleCodeExporter commented 9 years ago
(Fixed - I don't know if I can actually remove the listed issue though)

Original comment by danbry...@gmail.com on 10 Nov 2011 at 10:19

GoogleCodeExporter commented 9 years ago
Thanks :)
You don't remove issues when they are fixed, you just give them a "closed" 
status. In this case I used "Verified because I have checked your changes in 
game. You should have used "Fixed" because you have fixed the problem but the 
person who created the issue (me) hadn't confirmed it yet.

Original comment by lewinjh@gmail.com on 11 Nov 2011 at 4:15

GoogleCodeExporter commented 9 years ago

Original comment by kromster80@gmail.com on 28 May 2013 at 8:30