search

ttyridal / masterpassword-firefox

masterpassword for Firefox
GNU General Public License v3.0
33 stars 9 forks source link

Bug: MP does not recognize / populate password field consistently #39

Closed jamesdwilson closed 7 years ago

jamesdwilson commented 7 years ago

MP ver: 2.10b4

ff ver: 51.0.1

os ver:

linux mint 18 Linux thinkpad 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

  1. have mp set to autopopulate password field and to submit form
  2. load page
  3. click password field
  4. click mp firefox addon
  5. mp tries to populate and submit form
  6. mp fails to populate field, and does try to submit form.

expected:

  1. mp should populate password field
  2. should submit form

actual:

  1. mp does not populate password field
  2. mp attempts to submit form, but fails due to missing password

notes:

if i select the password field and hit the icon again, after once or twice again it eventually works.

ttyridal commented 7 years ago

Hi,

is this on some particular site or all of them? was it working better with the previous version? (the password inject was "improved" in beta4)

jamesdwilson commented 7 years ago

Try with creditkarma.com

jamesdwilson commented 7 years ago

Also mint/intuit

ttyridal commented 7 years ago

Thanks.. I can reproduce it. will look into it asap. I'm guessing it's a timing issue. The inject script runs on document_end, so one hypothesis is that your too fast / the site is too slow.. Not sure if that's actually required.

ttyridal commented 7 years ago

Are you sure it actually tries to submit the form ?

When I'm trying to reproduce the error I get a "No password field found" error in the browser log (Ctrl-Shift-J). Log window need to be open before clicking MP button.

It appears to be a timer that is a bit too tight.

ttyridal commented 7 years ago

hopefully fixed in beta 5