search

ttyridal / masterpassword-firefox

masterpassword for Firefox
GNU General Public License v3.0
33 stars 9 forks source link

firefox plugin creates a different password than mpw or masterpassword-jui.jar #64

Closed promeneur closed 2 years ago

promeneur commented 3 years ago

Firefox plugin creates a different password than mpw or masterpassword-jui.jar for example for bz.apache.org.

It seems that ff plugin uses v1 algorithm instead of v3.

Same problem with chrome plugin.

promeneur commented 3 years ago

The problem comes from FF plugin calculates the password with apache.org. mpw and masterpassword-gui calculates the password with bz.apache.org

ttyridal commented 3 years ago

Hi, this plugin should be using v3 of the algorithm (v2 and v3 differs to v1 in handling characters outside us-ascii in site names and main username/password). Are you sure that's the problem? Your example revolves around the site name. By default the plugin uses the two last parts of the site name (unless it's .co.*, if i remember correctly). You are free to change that when the dialog opens.

That would be a duplicate of as issue #52 i think

The algorithm for selecting the default is very stupid, it should be improved to take the best match or the one used previously for the site in question, but that's another story.

ttyridal commented 2 years ago

the site name is a user input, the addon only provides a suggestion.