ttyridal / masterpassword-firefox

masterpassword for Firefox

GNU General Public License v3.0

33 stars 9 forks source link

Emoji based on full name & password #82

Closed ghost closed 2 years ago

ghost commented 2 years ago

Changes

2 emojis are added in the popup page based on the Full name and master password so that the user can know if the password is correct or not.

Image Screenshot 2022-03-05 at 4 14 35 PM

ttyridal commented 2 years ago

Hi, this looks interesting.

We kinda already have the same with the 'verify' word at the bottom (after login) and a warning if it doesn't match your previous typed password, but why not?

Is this the same algorithm as some other implementation is using?

ghost commented 2 years ago

Thanks for the quick reply.

Is this the same algorithm as some other implementation is using?

No, I am converting char to ASCII values and based on that converting them to emoji.

ghost commented 2 years ago

restricted emoji between &#128512 - &#128590. These are emojis in this range. 😀 😁 😂 😃 😄 😅 😆 😇 😈 😉 😊 😋 😌 😍 😎 😏 😐 😑 😒 😓 😔 😕 😖 😗 😘 😙 😚 😛 😜 😝 😞 😟 😠 😡 😢 😣 😤 😥 😦 😧 😨 😩 😪 😫 😬 😭 😮 😯 😰 😱 😲 😳 😴 😵 😶 😷 😸 😹 😺 😻 😼 😽 😾 😿 🙀 🙁 🙂 🙃 🙄 🙅 🙆 🙇 🙈 🙉 🙊 🙋 🙌 🙍

ghost commented 2 years ago

Hi @ttyridal, any update on this issue?

ttyridal commented 2 years ago

Yep, just forgot about it :)