⬆️ update MacOS runner versions in GitHub CI pipeline

ttytm / wthrr-the-weathercrab

🌞 🦀 🌙 Weather companion for the terminal. Rust app.

https://crates.io/crates/wthrr

MIT License

394 stars 25 forks source link

⬆️ update MacOS runner versions in GitHub CI pipeline #349

Closed kevinmatthes closed 3 months ago

kevinmatthes commented 4 months ago

@ttytm

This PR fixes #348. I replaced macos-11 with the newer macos-12 and macos-13 settings. Furthermore, in release.yml, I also added further compilation targets such that MacOS versions 12 and 13 will both be targeted with x86_64 as well as arm64 architectures.

I would like to ask you to review these changes.

github-actions[bot] commented 4 months ago

Test Results

9 tests ±0 9 :white_check_mark: ±0 1s :stopwatch: ±0s 1 suites ±0 0 :zzz: ±0 1 files ±0 0 :x: ±0

Results for commit 813f7efc. ± Comparison against base commit 7560989e.

:recycle: This comment has been updated with latest results.

kevinmatthes commented 4 months ago

Drafted due to some bugs to be fixed.

kevinmatthes commented 4 months ago

@ttytm

I am sorry, my changes keep failing. Do you have an idea what could have gone wrong?

ttytm commented 4 months ago

Hey @kevinmatthes,

Thanks for your efforts!

Yes, the macos-11 runner images were removed after a period of downtime.

Apparently it's still a problem using the toolchain out of the box on the newer mac intel runners. The same failures were the reason I fall back to the old runner for x86 compilation instead of using the macos-13 runner already.

Manually setting up the rust toolchain might work.

kevinmatthes commented 4 months ago

@ttytm

Thank you for your review! 👍

I have already tried to setup Rust manually in 08a531fe204d22ac3c55dd1c82f669c98edbb82b where I called the installation script for rustup. It did not work as expected, so I switched to the current solution using a GitHub Action.

I will keep thinking about this issue, maybe I can find some other approach...

kevinmatthes commented 4 months ago

This comment is just for documentation of the last commits.

I removed MacOS 12 runners in both release and CI workflows.
I switched back to manual Rust re-installation on the MacOS 13 hosted runner as this might be a better starting point for a solution to the problem.
I added an explicit directory creation instruction to ensure that the target directory actually exists.

The rustup approach always fails when it comes to copying the downloaded Rust components to ~/.cargo/bin/rustup. As the directory is now guaranteed to exist, there must be some issue about the source directory...

ttytm commented 3 months ago

Thanks again!

kevinmatthes commented 3 months ago

Adding super user permissions to the execution of the rustup installation script does not help, either...