search

tu-graz-library / invenio-pure

MIT License
0 stars 3 forks source link

config variables #11

Open mb-wali opened 3 years ago

mb-wali commented 3 years ago

Also for configuration variables - it's better to use a prefix such as INVENIO or PURE to all newly added config vars. open for discussion @utnapischtim .

Originally posted by @mb-wali in https://github.com/tu-graz-library/invenio-rdm-pure/pull/9#r514189423

utnapischtim commented 3 years ago

do you mean that all configuration variables should start with the same prefix?

for me it would be the best to distinguish between configuration variables who belong to the repository prefixed by INVENIO and those which belong to the pure system prefixed with PURE.

so we have the following configuration variables

and the following configuration variables

should remain as they are.

SIDE NOTE:

The INVENIO_HOST_URL and the other 2 mentioned above are not more longer here. After the switch to the internal api they should be removed. Therefore i would not put that much effort in those things.

BUT nevertheless in my opinion we should distinguish between the repository part and the target system

further there are the following configuration variables:

as i remember correctly those two configuration variables are to select/create the user in the repository which is used to associate the created records by the cli/celery/cronjob. Therefore INVENIOPURE in the prefix.

mb-wali commented 3 years ago

Yes - I mean all the config variables should start with the same prefix. Because the module is injecting the config variables with prefixes SEE HERE