search

tuananh / camaro

camaro is an utility to transform XML to JSON, using Node.js binding to native XML parser pugixml, one of the fastest XML parser around.
MIT License
556 stars 29 forks source link

Is the method "ready" not required any more? #102

Closed leon closed 4 years ago

leon commented 4 years ago

the "ready" function is no longer exported in version 5.0.0 does that mean that we don't need to call it, or that you missed exporting it?

leon commented 4 years ago

I tried it without ready and it's telling me

"camaro is not yet initialized. You need to call ready() first."

So I think you need to export the function :)

tuananh commented 4 years ago

@leon the method ready is new in v5. it is exported https://github.com/tuananh/camaro/blob/develop/index.js#L79

you can find the example usage from tests

https://github.com/tuananh/camaro/blob/develop/test/basic.test.js

tuananh commented 4 years ago

Closed in #104