tuankhac / share-extras

Automatically exported from code.google.com/p/share-extras
0 stars 0 forks source link

Bad z-index when using PdfJs for pdf preview #128

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Open a pdf document details
2. Try to execute an action on the document from the right-column (change type 
for example)

What is the expected output? What do you see instead?
Expected new frame above the pdf instead of it being hide under document preview

What version of the add-on are you using? Please provide version of the
downloaded package, or Subversion revision number.
Latest version downloaded from here

What version of Alfresco are you using? On what application server?
Alfresco 4.2.c Community on tomcat 7.0.34

What web browser are you using? Please supply browser name and version.
Chrome 23.0.1271.64 m

Please provide any additional information below.
The bug shows only with PdfJs previewer, not Embed.
Screenshot example added on this issue.

Original issue reported on code.google.com by stefano....@gmail.com on 31 Jan 2013 at 1:58

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks for reporting.

The attached images shows that this is an issue with the Embed viewer. In the 
image it is actually Chromes built in viewer displaying the pdf in an iframe.

I will look into options for fixing this
- Fix the z-image for the iframe. This is not so easy, since external plugins 
not always respect z-index.
- Detect/catch that a dialog is opened, if so hide the iframe (adding an 
optiona button to open again).

Original comment by loftux.p...@gmail.com on 1 Feb 2013 at 3:19

GoogleCodeExporter commented 8 years ago
Same issue as #113

Original comment by loftux.p...@gmail.com on 1 Feb 2013 at 3:22

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
Thanks for your comments. Why are you saying it's Embed viewer? In my  
tomcat/shared/classes/alfresco/site-webscripts/org/alfresco/components/preview/w
eb-preview.get.config.xml I set: 

<plugin-conditions>
      <condition mimeType="application/pdf">
         <plugin>PdfJs</plugin>
         <plugin>Embed</plugin>
      </condition>

      <!--
          Enables the PdfJs viewer for other content which can be transformed to PDF or Embed in older browsers.
      -->

      <condition thumbnail="pdf">
         <plugin src="pdf">PdfJs</plugin>
         <plugin src="pdf">Embed</plugin>
      </condition>

How can I distinguish wich plugin it's using? From log file?

Original comment by stefano....@gmail.com on 1 Feb 2013 at 5:27

GoogleCodeExporter commented 8 years ago
I'm saying this beacuse the PdfJs viewer does not look like the chrome built in 
viewer, and that is what's in your screenshot.

What may have happened for you (so that the Embed viewer is used)
- The PdfJs viewer failed for some reason. The viewer mechanism test each 
viewer in order to find one that can display the content. So it first tested 
the PdfJs viwer, it failed, but then the Embed viewer worked. Why I can't tell.
- Or, you have double config files somewhere in your class path.

The issue is now resolved by
http://code.google.com/p/share-extras/source/detail?r=1437
The iframe with the plugin is hidden as soon as a dialog is or menu is opened.

Original comment by loftux.p...@gmail.com on 2 Feb 2013 at 1:43

GoogleCodeExporter commented 8 years ago
Issue 113 has been merged into this issue.

Original comment by loftux.p...@gmail.com on 2 Feb 2013 at 1:45