search

tuanle618 / AEDA

AEDA - Automated Data Exploratory Analysis in R
GNU General Public License v3.0
10 stars 3 forks source link

added header and cleaned up rmd chunks #26

Closed MiGraber closed 6 years ago

MiGraber commented 6 years ago

Code you can use to checkout the new "design"

data("airquality")
my.report.task = makeReportTask(id = "test.report", data = airquality, target = "Wind")
basic.report = makeBasicReport(my.report.task, data = airquality)

my.creport.task = makeCorrTask(id = "corr.report", data = airquality)
my.creport = makeCorr(my.creport.task)
corr.report = makeCorrReport(my.creport, type = "CorrPlot")

finishReport(basic.report, corr.report)
tuanle618 commented 6 years ago

looks good. As of now we can let the selected theme. We might change it in future. In date I noticed that when creating a file connection with file(...) we do not insert an encoding. Currently when selecting German language "ä" will be parsed as "?".

Please add in all write*Report and finishReport following line with encoding UTF-8 report.con = file(..., encoding = "UTF-8")

in https://github.com/ptl93/AEDA/blob/7a44ac8cda35ae85b26c9ffbdad0ef9083450a24/R/finishReport.R#L62 https://github.com/ptl93/AEDA/blob/7a44ac8cda35ae85b26c9ffbdad0ef9083450a24/R/writeBasicReport.R#L40 https://github.com/ptl93/AEDA/blob/7a44ac8cda35ae85b26c9ffbdad0ef9083450a24/R/writeCatSumReport.R#L35 https://github.com/ptl93/AEDA/blob/7a44ac8cda35ae85b26c9ffbdad0ef9083450a24/R/writeCorrReport.R#L29 https://github.com/ptl93/AEDA/blob/7a44ac8cda35ae85b26c9ffbdad0ef9083450a24/R/writeNumSumReport.R#L37

Pls merge afterwards