check all analysis' if NAs are in dataframe

tuanle618 / AEDA

AEDA - Automated Data Exploratory Analysis in R

GNU General Public License v3.0

10 stars 3 forks source link

check all analysis' if NAs are in dataframe #45

Closed tuanle618 closed 6 years ago

tuanle618 commented 6 years ago

I noticed that cluster analysis does not work with NAs. I will randomly insert NAs in testthat/base_finishReport file and check, if all analysis' can handle NAs or not.

In general: How should we handle missing Values? Omit them or do some kind of NA Imputation? Like columns average... ?

tuanle618 commented 6 years ago

I checked that only for getClusterAnalysis() NAs have to be removed. https://github.com/ptl93/AEDA/blob/528e7de643e5d7466e0f67f4afd8df856bfe6dc8/R/getClusterAnalysis.R#L56-L59

In all taskI added a parameter for showing message if a dataset contains missing values. As of now I believe only getNumSum() and getClusterAnalysis() can only work if we remove the NAs. In all other tasks there might be default options.

MiGraber commented 6 years ago

So is this issue "solved"?

tuanle618 commented 6 years ago

yes