search

tuatec / TTToolbox

TTToolbox provides useful helper scripts to automate your character integration workflows in Unreal Engine
MIT License
107 stars 29 forks source link

Add support of the curve methods for UE 5.3 #46

Closed Meruman closed 10 months ago

Meruman commented 1 year ago

Support of the "DumpSkeletonCurveNames", "CheckForMissingCurveNames" and "AddSkeletonCurve" methods for unreal engine version 5.3.0. Reason: the "AddSmartNameAndModify", "FSmartNameMapping" and a lot of other methods from the Skeleton class are now deprecated and no longer used.

AchimTuran commented 1 year ago

Thank you so much for creating this pull request! Do you already know if this will break support for 5.0, 5.1 and 5.2?

Deprecated means Epic removed the FSmartNameMapping class completely?

Meruman commented 1 year ago

Hi, sorry for the confusion, FSmartNameMapping class is still in the engine but some methods have changed. I know that 5.3 is still in preview but everything is in this commit: https://github.com/EpicGames/UnrealEngine/commit/502797ca50c381928f5dec3edac62208811a8417

And this are some of the methods that will be deprecated from the Skeleton.h file. image

I haven't tried it in 5.0,5.1 and 5.2 yet, it should not break support for those versions because the code check first if the engine is 5.3 or bigger but I will test it later today :)

Meruman commented 1 year ago

I just tested this code in 5.0, 5.1 and 5.2 without problems :)

AchimTuran commented 1 year ago

Sorry I missed your last message. I will take a deeper look into your changes next week. 😉

spcarso commented 10 months ago

I am on 5.3 and am stuck at this point. Your course is the first time I have touched C++ so I don't really know how to proceed. Anyway you could post here what I should change from your video?

AchimTuran commented 10 months ago

@Meruman Sorry for the long time I was not active. I needed a break. But the changes you did do not work with 5.3. The first error that occured is the new path for IKRigSolver.h. I really wonder how you got TTToolbox working with this branch. grafik

AchimTuran commented 10 months ago

@spcarso 

I am on 5.3 and am stuck at this point. Your course is the first time I have touched C++ so I don't really know how to proceed. Anyway you could post here what I should change from your video?

You should use the version I was using to following the videos if it is your first time touching C++. Many guys already tried to get the code base working with 5.3 but none so far made everything work. 😅

AchimTuran commented 10 months ago

Not sure yet if I will take over the changes in #48. As this pull request will not result in a successful build!

AchimTuran commented 10 months ago

Minimal needed changes for 5.3 are now available in #48. As so much has changed in 5.3 it is not possible to support 5.1 or 5.0 anymore.

Also a lot more effort needs to be spend to get TTToolbox fully working in5.3. it's the reason why I now Close this PR. 😉 5.3 support will be available soon.