calc whitespace not always preserved

[futtta]

An Autoptimize-user has CSS with a calc in it which gets broken. Whereas YUI-CSS-compressor-PHP-port normally preserves spaces, it does not in this case (confirmed using GUI)

Test input; input { width: calc(100% - (1em*1.5)); }

Expected output: input{width:calc(100% - (1em*1.5))}

Actual Output: input{width:calc(100% -(1em*1.5))}

Frank

[futtta]

improved fix; https://github.com/futtta/YUI-CSS-compressor-PHP-port/commit/5cadbf1dcced636c87a44cb519c398f50a0bc71a

[rostik]

seems like it fixes "- (" but not ") -"

[futtta]

can you try with this commit @rostik ?

[rostik]

@futtta that didnt work, but i did this, not sure if its correct, but it worked

$this->preserved_tokens[] = preg_replace('/([+-]{1})(/','/$1 (/',trim(pregreplace('/\s([_\/(),])/', '$1', $matches[2])));

[futtta]

yeah, had a stupid mistake in my code (forgot re-replacing $calc by $matches[2]) cfr. this commit.

can you try again?

[rostik]

this works. thanks! @futtta

[futtta]

great, thanks for testing & confirming! :-)

[sambolek]

Can this fix be implemented into the mainline please?

[tubalmartin]

Thank you for the fix. I'll release it this week ;)

[futtta]

great to see you're back @tubalmartin :-)

[tubalmartin]

Fixed in v2.4.8-p7 release. Thank you guys!