tubalmartin / YUI-CSS-compressor-PHP-port

A PHP port of the YUI CSS compressor.
230 stars 34 forks source link

fiing flexbox percentage remove problem #26 #32

Closed glensc closed 7 years ago

glensc commented 8 years ago

As requested by @damienmckenna in issue (https://github.com/tubalmartin/YUI-CSS-compressor-PHP-port/issues/26#issuecomment-221918492).

supersedes #30 by @futtta

NOTE: this fix is still needed for MSIE 10-12

glensc commented 8 years ago

@tubalmartin do you still maintain this project?

glensc commented 7 years ago

@tubalmartin give someone developer privileges if you're that busy. you can consider me.

futtta commented 7 years ago

I second @glensc 's proposal, we need someone who can keep tabs on stuff!

glensc commented 7 years ago

@tubalmartin err, why you just closed this PR with no explanation or changes?

tubalmartin commented 7 years ago

Sorry for that, last week or so I released a version that fixed this, and I'm about to release v3 which takes care of this too.

glensc commented 7 years ago

don't forget to cherry-pick the tests i added to this PR.

tubalmartin commented 7 years ago

This is fixed in v2.4.8-p10 and v3.0.0. Enjoy!

glensc commented 7 years ago

crazy how you update this repository. can not understand anything if you just upload dozen of changes with same commit. git is not ftp :)

tubalmartin commented 7 years ago

It's been quite a rewrite, not a patch ;)

tubalmartin commented 7 years ago

But I see no real issue trying to figure out the changes I've done from previous versions to v2.4.8-p10 for example. Check this out: https://github.com/tubalmartin/YUI-CSS-compressor-PHP-port/commit/e53c4d1fd0cec08fc05ddf10e21851baac3d0ad2#diff-80f11f7052c350cef68c3041a5479789

v3.0.0 is a different story since that is almost a complete rewrite.

glensc commented 7 years ago

i can't make heads or tails of the huge commit. i'll just assume you applied fix and added test.

and even complete rewrite can be achieved normally with normal commits not single commit replacing everything.

let it be.