tubalmartin / YUI-CSS-compressor-PHP-port

A PHP port of the YUI CSS compressor.
230 stars 34 forks source link

issue Number #51 : Resolved PHP 7.2 compatibility #54

Open shital7mahajan opened 5 years ago

shital7mahajan commented 5 years ago

There are a couple of minor PHP 7.2 incompatibilities in this project, both in gui/index.php:

ini_set('magic_quotes_sybase', 0); --> this directive has been removed. I guess it's safe also to disable it. parse_str($_POST['options']); --> parse_str now requires the return parameter to be set. I searched across the code and couldn't find Would it be ok to raise the PHP minimum version requirement? I can raise a PR if you want

panvid commented 3 years ago

Does this PR will be merged and ticket solved?