PHP 7.4 fixtures - Githubissues

tubalmartin / YUI-CSS-compressor-PHP-port

A PHP port of the YUI CSS compressor.

230 stars 34 forks source link

PHP 7.4 fixtures #57

Open panvid opened 4 years ago

panvid commented 4 years ago

There are some little changes in PHP 7.4 with could break the normal usage of cssmin. Perhaps these things can be fixed:

get_magic_quotes_gpc() is deprecated, see https://github.com/tubalmartin/YUI-CSS-compressor-PHP-port/blob/master/gui/index.php#L41

futtta commented 4 years ago

But as the code specifically tests if the function exists before trying to use it, there's very little that can go wrong there? if (function_exists('get_magic_quotes_gpc') && get_magic_quotes_gpc()) {

panvid commented 4 years ago

In 7.4, the function exists, but throws a deprecation information, see https://www.php.net/manual/de/migration74.deprecated.php#migration74.deprecated.core.magic-quotes-functions

See: https://3v4l.org/YLTW5

futtta commented 4 years ago

Sure, but a deprecation notice does not break the normal usage of cssmin ;-)

panvid commented 4 years ago

Normal production software should never ignoring deprecation warnings, so this problem will throw many log hints ;)