search

tubbo / openrct2-benchwarmer

An OpenRCT2 plugin that adds alternating benches and bins to your park's footpaths with a single click.
MIT License
38 stars 9 forks source link

Unable to use this plugin when the map does not use money #31

Closed telk5093 closed 4 years ago

telk5093 commented 4 years ago

This plugin is great but it is unable to use it at infinite money map such as Icicle Worlds. Especially the map which has $0 when uncheck "No money" cheats.

tubbo commented 4 years ago

I don't have the means to test this on Icicle Worlds, but I tested it on Extreme Heights just now and everything seems OK to me...the benches & bins built just fine. When you say "infinite money", you mean "no money", right? As in, no park entrance fees, no advertising, no profits...you just build stuff.

telk5093 commented 4 years ago

Thanks for reply. It was not my case but someone told me ask.

I meant there should be exception for the parks with infinite funds. It seemd that there is a park with $0 cash with inifinite funds and a park with positive funds with infinite funds. Icicle Worlds is former. You may check via cheats by enabling/disabling No Money cheat at Icicle Worlds.

I think there is no exception code for infinite funds, according to here.

tubbo commented 4 years ago

I don't understand how a park can have $0 cash and "infinite funds". Tried enabling and disabling No Money on Extreme Heights and I'm still able to build benches.

telk5093 commented 4 years ago

I meant the scenario with infinite money and its hidden(internal) cash value is zero, so that I can check it by disabling No Money cheat like below: icicle worlds

After I re-enable No Money cheat, benches aren't built. Extreme Heights had $110,000 cash internally when I've checked.

Edit) More GIF: z

tubbo commented 4 years ago

ah i see, i guess some parks start out with $0. i was able to (sorta) reproduce the issue on extreme heights. it turns out that the plugin will still deduct money if any money exists, and in a "no money" scenario, your park still has a cash value. hopefully we can know when money has been turned off and then not deduct cash if the park has infinite money. thanks for the screenshots!

tubbo commented 4 years ago

@telk5093 can you try out this build and see if it works for you? https://github.com/tubbo/openrct2-benchwarmer/suites/1389973851/artifacts/22961199

telk5093 commented 4 years ago

@tubbo Works fine 👍

tubbo commented 4 years ago

nice, i'll release 0.4.1 then :)