search

tube0013 / esphome-stream-server-v2

Custom Component for ESPHome enabling Serial over TCP
33 stars 25 forks source link

AsyncTCP #7

Closed ctvedt closed 10 months ago

ctvedt commented 1 year ago

Looks like esphome updated/included AsyncTCP in in april (https://github.com/esphome/esphome/pull/4764), which now includes the logic regarding library for ESP8266/ESP32. So this PR removes the AsyncTCP include, as it seems to be part of esphome core now: https://github.com/esphome/esphome/blob/dev/esphome/components/async_tcp/__init__.py

opsnlops commented 10 months ago

This is biting me, too! I ended up changing my YaML file to pull @ctvedt's branch rather than this one because this issue prevents the stream server from compiling on the current version of esphome.

TheJulianJES commented 10 months ago

I've been using oxan's original code without issues on every new ESPHome version since months or so and it's been fine.

opsnlops commented 10 months ago

I've been using oxan's original code without issues on every new ESPHome version since months or so and it's been fine.

I just tested this. There's a problem with the binary_sensor.stream_server in the default config if you use @oxan's version:

binary_sensor.stream_server: [source zigbee-coordinator.yaml:108]

  'connected' is a required option for [binary_sensor.stream_server].
  platform: stream_server
  stream_server: ss
opsnlops commented 10 months ago

Thank you!

TheJulianJES commented 10 months ago

I just tested this. There's a problem with the binary_sensor.stream_server in the default config if you use @oxan's version:

(not regarding this PR, but your comment). You're using Tubes example code. Not oxan's code. You need to change the binary sensor slightly to be like this if you want to use oxan's code: https://github.com/oxan/esphome-stream-server#sensors