tube42 / drumon

FOSS drum app for Android
GNU General Public License v2.0
91 stars 13 forks source link

maintenance #11

Closed TacoTheDank closed 5 years ago

TacoTheDank commented 5 years ago
tube42 commented 5 years ago

I am sorry, I cannot accept this PR.

There are some good stuff in here but there are also a lot of formatting changes that will reverted back by my editor as soon as I change a file. This will result in huge commits back and forth with minimal real value.

I recommend you do a minimal PR with only the stuff that absolutely must be updated and no formatting changes.

TacoTheDank commented 5 years ago

Alright, that works, thank you. Could you perhaps tell me what things are automatically changed by your editor, so that I could avoid touching that stuff?

tube42 commented 5 years ago

First of all, I am thankful for your contributions so don't let what follows below discourage you from continuing your work.


The golden rule of commits is that it must change as little as possible, even (in fact ESPECIALLY) when it fixes things that look ugly. See this discussion to learn why:

https://softwareengineering.stackexchange.com/questions/83554/formatting-code-a-bad-thing-when-using-a-vcs

Now, in #12 look at your changes to, say, DrumApp.java. Are there ANY changes in there that are not formatting changes? In fact, your commit updates 54 files where your actual changes touched no more than 3-4 files and then only 1-2 lines in each.