search

tube42 / drumon

FOSS drum app for Android
GNU General Public License v2.0
85 stars 13 forks source link

i think this is better #12

Closed TacoTheDank closed 5 years ago

TacoTheDank commented 5 years ago

how about it?

tube42 commented 5 years ago

I see four different types of changes here:

  1. updates to android versions, tools and so on
  2. updates to files created automatically by libgdx, gradle and so on
  3. automatic reformatting to XML and java files, probably by your editor
  4. some text changes, for example in README.rst

Could you give me a PR that contains only part 1?

TacoTheDank commented 5 years ago

The java file changes weren't formatting changes; I edited those myself. I only changed necessary parts of the java files (i.e. removing imports that weren't being used, optimizing code, etc) and tried to change as little as possible. Also, I work in Android Studio and Notepad++ (which doesn't automatically change anything).

TacoTheDank commented 5 years ago

Nevertheless, I'll revert formatting changes and only push changes that actually benefit the project.

TacoTheDank commented 5 years ago

(removed previous commits and made these off of those, much fewer changes)

tube42 commented 5 years ago

Sorry mate, this fails to build on my machine.

Have you tested building this without Android Studio (using gradle) or even better on the f-droid virtual machine?

TacoTheDank commented 5 years ago

Oh I forgot about this, no I haven't tested it without Android Studio... I'll try some stuff