search

tube42 / drumon

FOSS drum app for Android
GNU General Public License v2.0
85 stars 13 forks source link

FR: Export audio file? #13

Open randomuser112358 opened 5 years ago

randomuser112358 commented 5 years ago

Hello.

First of all thank you for this nice app.

Would it be possible to add audio (MIDI/OGG/other) file export? Would be nice for ringtones.

tube42 commented 5 years ago

Its pretty straight forward to export to WAV. The only problem is that it would require storage access permission which some people (including me) don't like.

francwalter commented 4 years ago

Could you give a hint how to proceed? Maybe as a plugin, so everybody can choose... Would be a great feature.

catprisbrey commented 4 years ago

Indeed, when I use the export, it copies to the clipboard and the notification says it can be emailed from there, but it appears to just be short text output, but I'm uncertain where to go from here.

tube42 commented 4 years ago

import/export on the save page does not generate a wave file, it creates a textual representation of the current track so you can send your latest masterpiece to your friend via email.

sorry for the confusion :)

What you need is to render-to-file, but that would require the app to access your phones storage. That is currently not supported because I don't want my app to have access to your files.

I think there is a solution to this in Android 10, but I need to investigate it further.

Uj947nXmRqV2nRaWshKtHzTvckUUpD commented 3 years ago

As long as the app does not have internet connection, and it's open source, which is the problem of having storage access ? Even if i like the app, i find it a bit useless in the end without being able to export my masterpiece as mp3 or wav or whatever.

ameaninglessname commented 3 years ago

Why just generate the file at the app's data folder? Then, it's no need for storage access?

tube42 commented 3 years ago

You cannot access the local app folder from other apps or a file browser.

I have added initial code to use the system file picker which bypasses the access requirements but I have not had time to code the rest.

orogenic commented 3 years ago

Is this a permissions concern if the permission can be denied by default and the user must explicitly grant it in order to save the rendering to storage? Is storage access required to share a rendering to another app? Or is storage access required to render to memory then share?