Code cleanup and adaptive icon - Githubissues

tube42 / drumon

FOSS drum app for Android

GNU General Public License v2.0

85 stars 13 forks source link

Code cleanup and adaptive icon #26

Closed TacoTheDank closed 3 years ago

TacoTheDank commented 4 years ago

Hey, it's been a while.

Commit 1

Add .iml and .idea to .gitignore

Commit 2

Updated fonts from https://fonts.google.com/specimen/Roboto and https://fonts.google.com/specimen/Roboto+Condensed

Commit 3

Cleaned up tons of unused imports
(I did not authorize the IDE to do this, I don't know why it went and did that anyway)

Commits 4-11

Miscellaneous lints were fixed

Commit 12

Created a rudimentary adaptive icon from the icon.svg in extras. The app icon will now look much nicer on Android devices.

TacoTheDank commented 3 years ago

@tube42 Sounds good to me! I'll make some changes. I hope it improves it.

The adaptive icons will only work for Oreo and above, which is okay because regular icons were also made for versions below Oreo (the pngs).

tube42 commented 3 years ago

I did a manual merge with some of the commits.

The round and adaptive icons doesn't work with the way art files are processed here, I need to look into that first.

TacoTheDank commented 3 years ago

@tube42 Alright, thanks.