search

tubearchivist / browser-extension

Tube Archivist Companion for your Browser
GNU General Public License v3.0
131 stars 18 forks source link

Subscribe and join buttons overlap #10

Closed mattkdoggie closed 1 year ago

mattkdoggie commented 1 year ago

The subscribe and join buttons overlap when there is not enough space horizontally. It also cuts off the channel info as well.

Example without join button -

Screenshot 2022-11-30 at 7 39 02 PM

Example with join button -

Screenshot 2022-11-30 at 7 39 52 PM
bbilly1 commented 1 year ago

I think I got this to behave nicer now. The channel name cut off is a YouTube thing. That will happen a bit sooner now with the additional button taking up space than it otherwise would. But I don't think we can avoid that. In any case, v0.1.1 will be out once it passes validations.

mattkdoggie commented 1 year ago

Looks better but I'm now getting the like button to overlap in some situations. Example -

Screenshot 2022-12-02 at 7 46 03 AM

This is only happening in a very narrow width.

bbilly1 commented 1 year ago

Sometimes it needs a page refresh for the other youtube buttons to realize there isn't enough space anymore, sometimes it doesn't trigger on window resize. If you want to keep tinkering with it, please do. We can always also finetuning it as we go.