Closed bakkot closed 1 year ago
Is this actually functional? Since this PR the dlButton.setAttribute('data-id', videoId)
is gone, so no data-id
is set on the button, but the sendDownload()
still references it.
I've tried using the extension off the master branch and the button doesn't work for me.
Edit: While that seems broken it's only triggered through the code path that's only accessible when you're not logged in
Probably best to review the second commit individually; the first one is a
git revert
of https://github.com/tubearchivist/browser-extension/commit/aaa04a43b5eaf14f8763390a2f6065c0ac87d8dc so that the second one makes more sense.The idea is that whenever the
channelContainer
element is updated (per a MutationObserver) we check to see if the handle has changed, and if so replace the subscribe/download buttons with new buttons.