search

tubearchivist / browser-extension

Tube Archivist Companion for your Browser
GNU General Public License v3.0
131 stars 18 forks source link

Extension buttons cut off content #32

Open p0358 opened 9 months ago

p0358 commented 9 months ago

Download button cuts off video titles

With addon: obraz Without: obraz It's quite annoying, because creators create their titles to be displayed under regular YT apps to be comprehensible, and when they're cut off more, it doesn't make sense as you often don't even know what the video is about anymore.

The issue is there's a download button from TA there, and it sits there on the right with opacity: 0. So the solution is to either have it do display: none instead of opacity: 0, or to do something like position: absolute; right: 2rem;, which would then look like this: obraz

Or even position: aboslute; right: 0; top: 3rem; (in this case the button should be shown on hover over whole card and not just title though): obraz

In general though I find these buttons pretty questionable. I think each of them should be configurable, on whether they should be shown at all. The reason is that a lot of people would have used this extension in the first place to just sync their cookies, and anything beyond that was just an extra (personally I had to disable cookie syncing as it was breaking yt-dlp lately, which now makes me question if I even need this extension enabled at all currently xd)

Subscribe/download combo cuts off channel name

obraz Almost equally bad. What channel am I even watching?

This happens because YouTube sets their responsive layout with the assumption that only the buttons they put there would be there, and even they themselves would have often gotten it wrong and caused things to get cut off, hilariously. But with an extra wide button, any issues with this layout are only amplified sadly (under certain screen widths...).

I think in this case it'd be better to make the button much tinier, preferably just a tiny button with TA logo, that'd show dropdown with these options. And to "Subscribe" and "Download", there could be one named something like "Open in TA instance" added, to show the video if it's already there.

bbilly1 commented 9 months ago

Looks like you know what to do, please go ahead.

Overlaying the video download button over the title might work, you'd have to try and see how this work throughout the interface. The screenshot with the button under the title looks out of place though...

The cookie thing, there is already an issue open of what can be fixed from our side. Another problem is YT is revoking tokens server side if a cookie gets used outside of a browser context. I've thought of removing cookie functionality alltogether, but it still seems to be working for some, hence just the big fat warning in the docs instead.

Subscribe/download button, YT has been changing things around, that has worked better before as YT would treat it as an internal button and adopt the interface, not anymore it looks like. But still, most people will have 1080p+ screens, so that shouldn't apply to them.

Looking forward to your PRs improving things here.

Going forward, please avoid words like "annoying", "hilarious", "bad". These are not nice words to use when talking about open source projects.

p0358 commented 9 months ago

Going forward, please avoid words like "annoying", "hilarious", "bad". These are not nice words to use when talking about open source projects.

Sorry, didn't mean to sound rude. Though to clarify, I used "hilarious" only in the context of mocking YouTube itself, because they had such issue in the stock interface too, in some channels that had too many buttons, like those where you can buy channel-specific subscription and other stuff (and in those cases you'd see channel name like that even on big screen (with the addon more often too in turn))

I'll see what I can do tomorrow