search

tubearchivist / browser-extension

Tube Archivist Companion for your Browser
GNU General Public License v3.0
131 stars 18 forks source link

Extension includes cookies from other extensions unrelated to youtube #42

Open chrisliebaer opened 2 months ago

chrisliebaer commented 2 months ago

This issue might be somewhat related to #22

I'm using the extension https://github.com/Cookie-AutoDelete/Cookie-AutoDelete on Firefox.

When attempting to download a video with the extension, Tube Archivist fails with cookie file is invalid: invalid Netscape format cookies file

And when inspecting the request I can see, that the Tube Archivist browser extension included the following cookie

www.youtube.com TRUE    /<redacted-possibly-random-code>    FALSE   1751875552  CookieAutoDeleteBrowsingDataCleanup CookieAutoDeleteBrowsingDataCleanup

So I'm no broser extension developer, I don't know if spilling into page cookies by Cookie AutoDelete is a good approach but I would also expect at least some extensions and user script to do the same.

I think it would be reasonable to filter out all cookies that don't match the format required by whatever tool generated the error message above, probably key=value.

bbilly1 commented 2 months ago

Well, it's not unrelated. It's a cookie for the domain www.youtube.com, so that is working as expected. Strange that this is invalid. Does removing that cookie make it work?

Ultimately, there is no expectation of compatibility with other extensions. If you want to make it compatible, please do.

chrisliebaer commented 2 months ago

Removing the cookie either from the request or from the cookie store does make it work. Of course the other extension is adding it back after the next page request but everything done before that will work.

As I understand it, the error originates from yt-dlp? I sadly don't have the entire debug output anymore but I think the other cookies passed to tubearchivist all had a value of somekey=somevalue and this one didn't. I guess I have a look at it.