tuberry / color-picker

Simple color picker for GNOME Shell.
GNU General Public License v3.0
150 stars 11 forks source link

Systray Icon Padding #40

Closed Batwam closed 1 year ago

Batwam commented 1 year ago

Hello,

Great extension! Minor gried but as gnome 40+ is quite liberal with icon padding, would it be possible to reduce the icon padding from (see elongated gray icon area) image to (see round icon area) image in order to reduce the space used by the icon and for consistency with other extensions: image

I'm also not sure why the version on github is version 1 so I updated that as otherwise, the extension updates itself automatically which is quite frustrating...

tuberry commented 1 year ago

Sorry for the late reply.

The padding depends on the system-status-icon style class , which is used by default by the upstream for indicator icons like a11y or kbd. IMHO, it is better to follow the upstream style.

Batwam commented 1 year ago

That's interesting as most other extensions seem not to follow the same padding. The padding around the wifi/sound/... icons also appear to be more similar to the icon without padding than the current one: image

Anyway, I just wanted to point that out as it didn't look consistent. Feel free to close this PR if you are happy with the way it looks currently.

tuberry commented 1 year ago

Many systray icons like caffeine basically use this style class to keep the icon size consistent, and I didn't do anything else to make its padding significantly more space than other extensions. So I don't think there is any need to reduce the padding intentionally. :(

I recommend using this extension to modify the style if necessary:

.system-status-icon {
    margin: 0;
    padding: 0;
}

pic

Anyway, thanks for your effort.