search

tuberry / extension-list

Simple GNOME Shell extension manager in the top panel.
GNU General Public License v3.0
57 stars 8 forks source link

Extension update caused GDM login to fail #15

Closed kabe-inc closed 1 year ago

kabe-inc commented 1 year ago

Hi, so I started my Endeavour OS up as normal yesterday but found that the DE was booting me back to the login screen.

A browse through journalctl showed this

Dec 09 22:54:45 endeavour gnome-shell[1549]: Execution of main.js threw exception: Module resource:///org/gnome/shell/ui/init.js threw an exception Dec 09 22:54:45 endeavour gnome-shell[1549]: JS ERROR: Gio.IOErrorEnum: Error removing file ~/.local/share/gnome-shell/extension-updates/extension-list@tu.berry/icons/hicolor/scalable/actions: Directory not empty recursivelyDeleteDir@resource:///org/gnome/shell/misc/fileUtils.js:48:13 recursivelyDeleteDir@resource:///org/gnome/shell/misc/fileUtils.js:44:33 recursivelyDeleteDir@resource:///org/gnome/shell/misc/fileUtils.js:44:33 recursivelyDeleteDir@resource:///org/gnome/shell/misc/fileUtils.js:44:33 recursivelyDeleteDir@resource:///org/gnome/shell/misc/fileUtils.js:44:33 _installExtensionUpdates/<@resource:///org/gnome/shell/ui/extensionSystem.js:588:27 collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:28:28 _installExtensionUpdates@resource:///org/gnome/shell/ui/extensionSystem.js:574:19 init@resource:///org/gnome/shell/ui/extensionSystem.js:56:14 _initializeUI@resource:///org/gnome/shell/ui/main.js:309:22 start@resource:///org/gnome/shell/ui/main.js:186:5 @resource:///org/gnome/shell/ui/init.js:6:17

I eventually managed to figure out that I could log in again by manually deleting the extension-updates subfolder.

Do you have any idea about what caused this in the first place?

tuberry commented 1 year ago

I'm very sorry for that.

Gnome shell automatically deletes the generated temporary files after updating the extension, but its code for recursively deleting folders does not take into account the symbolic link files in this update, thus causing the crash.

Now, I disabled this update on the E.G.O website. Manually delete the update folder and reboot should not crash again.

# press Ctrl+Alt+F4 to login to a tty
gio trash ~/.local/share/gnome-shell/extension-updates
reboot

Related upstream MR: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2571