search

tuckerconnelly / carbon-ui

React Native Material Design library for all platforms
MIT License
210 stars 17 forks source link

ReactInjection Missing from React 15.4.1 Install #3

Closed mattferrin closed 7 years ago

mattferrin commented 7 years ago

I'm just trying to get up and running and noticed React 15.3 contained a lib dependency that 15.4 doesn't.

simulator screen shot dec 9 2016 4 05 03 pm

tuckerconnelly commented 7 years ago

Ah yeah, need to add react to the peer dependencies. Make sure react 15.3.2 is installed:

npm -S i react@15.3.2

And in package.json remove the caret: "react": "15.3.2"

Waiting on https://github.com/tuckerconnelly/carbon-ui/issues/1 and https://github.com/necolas/react-native-web/pull/255 for 15.4 support :)

mattferrin commented 7 years ago

We'll need to know both the latest React and React Native versions that work. Trying to find the correct React Native version has me running into an issue that was fixed in later versions of React https://github.com/facebook/react-native/issues/4949.

tuckerconnelly commented 7 years ago

Ah gotcha, I think react-native 0.37.0 is the latest that works.

BTW, two example projects using carbon-ui over here if you need them: https://github.com/tuckerconnelly/react-stack-nav-examples

remon-nashid commented 7 years ago

Hurray! react-native-web is now compatible with latest React (necolas/react-native-web#255). Shall we start by bringing tuckerconnelly/react-native-web to latest RNW version?

tuckerconnelly commented 7 years ago

Okay yup, this is good to go :) Should work with the latest react now. It's tested and working on react-native@0.39, was having lots of unrelated problems from the breaking changes on 40 and still working through those.