search

tuckers-tech / angular-rust-electron

Desktop application using Angular and Electron, with Rust/Neon for data-heavy operations.
0 stars 1 forks source link

Adding e2e test with Spectron #5

Open agomezru opened 3 years ago

agomezru commented 3 years ago

Hi again!

Is that project open to MR? I'm trying to add a new branch, and I'm getting 403 error.

Let me explain my purpose.

I'm using your project as base for my personal project and I want to add integration test to it. I've found that solution : https://github.com/HackTzi/app-desktop-hacktzi

I decided to add that tests to your project, to learn how it works, and then add it to mine. I have a SSH key on my profile, but I'm getting a 403 when I push the branch.

I attach here my changes in a zip file. You could take a look on them, and let me know if you want to add them. Maybe you don't. There's no problem at all of course.

Thanks!

angular-rust-electron.zip

tuckers-tech commented 3 years ago

Hi!

Absolutely, I'm open to PRs! You can never have too many tests!

How are you trying to add changes? Are you pushing directly to the repo? That will fail unless you are deemed a "collaberator" on the project. If you aren't a "collaberator" on a project (this case) you can submit a PR by forking the repo, making your changes on the fork, and then submitting a PR from that fork to the main repo. I just tested with a test account I have and that worked for me. Give it a shot and I'll take a look at the PR! Let me know if you have any questions!