search

tud-amr / localPlannerBench

Local Planner Bench
https://tud-amr.github.io/localPlannerBench/
GNU General Public License v3.0
49 stars 5 forks source link

Inclusion of dev-only dependencies results in version conflict with existing dependencies #17

Closed niketagrawal closed 2 years ago

niketagrawal commented 2 years ago

Installing development-only dependencies such as pytest, black and pylint conflicts with the version of Python pinned in pyproject.toml (python = '^3.6,<3.11'), for example, latest version of black needs python >3.6.2

maxspahn commented 2 years ago

Can you specify where black, pylint, pytest are required by the project? It is currently not listed as a dependency in the pyproject.toml file.

niketagrawal commented 2 years ago

Can you specify where black, pylint, pytest are required by the project? It is currently not listed as a dependency in the pyproject.toml file.

Yes, these are currently not defined in pyproject.toml; these are dev-only dependencies. The potential future contributors to localplannerbench would use the poetry dev environment; it would be convenient if they can run tests locally, run static anlysis using linters, and format the code in the same dev environment. In order to do this, they would need to install pytest, black and pylint in the same dev environment.
Currently, installing a new dependency using thecommand poetry add <dependency> may throw an incompatible vrsion error because the existing pinned version of Python may conflict with it.

maxspahn commented 2 years ago

Solved in 5b64427