search

tud-cor / FS19_modROS

(partial) ROS1 integration for FarmSim19
Apache License 2.0
49 stars 12 forks source link

Introduce new `rosVehicle` specialization and `LaserScanner` class #44

Closed tckarenchiang closed 3 years ago

tckarenchiang commented 3 years ago

This PR is to fix #3, #15, #16.

Two new classes have been introduced:

  1. The specialization- rosVehicle: store the per-vehicle functionality/properties.
  2. The LaserScanner class: separate the laser scanners parts from modROS.lua to improve the readability and reusability
gavanderhoorn commented 3 years ago

Apologies for taking so long.

Holidays, etc. :slightly_frowning_face:

gavanderhoorn commented 3 years ago

@tckarenchiang: also noticed that luacheck isn't happy about something here.

Is that already fixed in a later commit (not part of this PR perhaps)?

tckarenchiang commented 3 years ago

@tckarenchiang: also noticed that luacheck isn't happy about something here.

Is that already fixed in a later commit (not part of this PR perhaps)?

It's fixed now

tckarenchiang commented 3 years ago

Apologies for taking so long.

Holidays, etc. 🙁

No problem. Thanks for the review 🙂