search

tud-phi / ros2-elastica

ROS2 package implementing Elastica
0 stars 0 forks source link

Rename rod_tip_orientation to orientation #22

Closed mstoelzle closed 2 years ago

mstoelzle commented 2 years ago

Please rename rod_tip_orientation_X to orientation_XX. You can add a code comment that you always refer to the orientation of the tip of the rod:

https://github.com/tud-cor-sr/ros2-elastica/blob/main/elastica_sim/elastica_sim/continuum_flagella_ros2.py#L42 https://github.com/tud-cor-sr/ros2-elastica/blob/main/elastica_sim/elastica_sim/continuum_flagella_ros2.py#L187

This is more in line with the common nomenclature

RUFFY-369 commented 2 years ago

Hi @mstoelzle , thanks for enhancing the namings, I've pushed the required commits regarding the same